Messages in this thread | | | Date | Thu, 01 Jul 2004 10:50:04 -0400 | From | Timothy Miller <> | Subject | Re: [PATCH] restore floppy boot image |
| |
Randy.Dunlap wrote: > On Wed, 30 Jun 2004 17:52:30 -0400 (EDT) Joshua wrote: > > | Thanks for the time in reading the patch. > | > | Hmm. pop %ax after the jmp is a clear bug. Must have been a zero > | on the stack when I tested it. <g> > | > | For the clobbering of al just before kernel entry, that is badly arranged > | code although it doesn't matter (mov $0, %al turns out to be no-op). > > No-op should be some form/variant of xchg %ax,%ax > (not mov to %al -- the latter needs to do something.)
He didn't mean it was a "nop". He meant that the operation had no effect because moving zero to a register which already contains zero accomplishes nothing.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |