Messages in this thread | | | Date | Wed, 9 Jun 2004 16:37:06 +0200 (CEST) | From | Jesper Juhl <> | Subject | Re: [PATCH] tiny patch to kill warning in drivers/ide/ide.c |
| |
On Wed, 9 Jun 2004, Andreas Dilger wrote:
> On Jun 09, 2004 03:38 +0200, Jesper Juhl wrote: > > drivers/ide/ide.c: In function `ide_unregister_subdriver': > > drivers/ide/ide.c:2216: warning: implicit declaration of function > `pnpide_init' > > > > I added a simple declaration of pnpide_init to drivers/ide/ide.c > > > > Here's a patch against 2.6.7-rc3 - please consider including it (or if > > that's not the way to do it, then don't) :) > Better to add the declaration into a header like linux/ide.h that is > included into both ide.c and ide-pnp.c so that when/if pnpide_init() > ever changes its prototype you will get a warning during compilation. > The only good reason to have declarations within .c files is for forward > declarations of functions only used in the same file.
That makes perfect sense. I actually considered making a header for it, but since it would contain only a single declaration I abandoned that - I see now that I should have done that in any case to avoid stuff becomming out of sync.
Would you like an updated patch ?
-- Jesper Juhl <juhl@dif.dk>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |