Messages in this thread | | | Date | Mon, 7 Jun 2004 11:56:37 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] Missing BKL in sys_chroot() for 2.6 |
| |
On Sun, 6 Jun 2004, BlaisorBlade wrote: > > (PLEASE cc me on replies as I'm not subscribed). > > Set_fs_root *claims* it wants the BKL held:
I think the set_fs_root() comment is just wrong.
We properly lock the accesses to root/rootmnt with "fs->lock", and in fact no other users will have the BKL when accessing them anyway, so I don't see what the BKL would help in this case.
However, from a quick grep of users, it does look like some other users aren't real careful with "fs->lock" (ie chroot_fs_refs() looks like it could have problems - probably purely theoretical).
Al, do your eagle-eyes see something I missed?
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |