lkml.org 
[lkml]   [2004]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: ethtool power manglement hooks
Alan Cox wrote:
> Several ethernet drivers have been broken by the ethtool support because
> the ioctl code used to power the interface up and down as needed. Rather
> than add this to each driver call Jeff Garzik suggested we add hooks
> for before/after ethtool processing.
>
> This patch implements them which makes fixing the PM stuff easier,
> as the epic100 patch to follow will show. It also cleans up the
> via-velocity driver pm/ethtool logic a great deal. As per Jeff's
> request the before handler is allowed to fail the operation.

Thanks A.

BTW, if you have a free moment, I don't think all your comments from
your months-ago review of net/core/ethtool.c were addressed. A
re-review would be appreciated. In the meantime, I'm hunting around for
your original review.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.051 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site