lkml.org 
[lkml]   [2004]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.6.6 memory allocation checks in drivers/pci/hotplug/shpchprm_acpi.c

Hello Randy, Yury,

Em Sun, Jun 06, 2004 at 10:51:06AM -0700, Randy.Dunlap escreveu:

| On Sun, 06 Jun 2004 19:20:51 +0300 Yury Umanets wrote:
|
| | Adds memory allocation checks in acpi_get__hpp()
| |
| | ./linux-2.6.6-modified/drivers/pci/hotplug/shpchprm_acpi.c | 2 ++
| | 1 files changed, 2 insertions(+)
| |
| | Signed-off-by: Yury Umanets <torque@ukrpost.net>
| |
| | diff -rupN ./linux-2.6.6/drivers/pci/hotplug/shpchprm_acpi.c
| | ./linux-2.6.6-modified/drivers/pci/hotplug/shpchprm_acpi.c
| | --- ./linux-2.6.6/drivers/pci/hotplug/shpchprm_acpi.c Mon May 10
| | 05:32:28 2004
| | +++ ./linux-2.6.6-modified/drivers/pci/hotplug/shpchprm_acpi.c Wed Jun
| | 2 14:28:07 2004
| | @@ -218,6 +218,8 @@ static void acpi_get__hpp ( struct acpi_
| | }
| |
| | ab->_hpp = kmalloc (sizeof (struct acpi__hpp), GFP_KERNEL);
| | + if (!ab->_hpp)
| | + goto free_and_return;
| | memset(ab->_hpp, 0, sizeof(struct acpi__hpp));
| |
| | ab->_hpp->cache_line_size = nui[0];
| |
| | --
|
| All other failure paths in this function use err() to inform the
| console about what's happening... so flip a coin, I guess:
| add a message or say that ACPI already has too many messages. :(

I sent the same patch for this some weeks ago. Dely accepted, but it was
not applyed. Don't know why.


--
Luiz Fernando N. Capitulino
<http://www.telecentros.sp.gov.br>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [from the cache]
©2003-2011 Jasper Spaans