lkml.org 
[lkml]   [2004]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.7-rc2-mm1
Joshua Kwan writes:
> On Tue, 01 Jun 2004 02:15:39 -0700, Andrew Morton wrote:
> > - merged perfctr. No documentation though :(
>
> In light of all of the problems with perfctr here, I've gone and done the
> ifdef work for CONFIG_PERFCTR, presenting an alternative solution to the
> struct problem...
>
> http://triplehelix.org/~joshk/perfctr.diff

What "all the problems"? There was an issue with warnings on
struct-declared-in-parameter-list when CONFIG_PERFCTR is disabled,
but those are trivial to fix and a fix was posted early on.

Your patch is #ifdef:ing out calls that have explicit no-op stubs
for the !CONFIG_PERFCTR_VIRTUAL case. This shouldn't be needed.
(And you're testing the wrong config option.)

Also _please_ include the maintainer of said code if you think
it has problems.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.799 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site