Messages in this thread Patch in this message | | | Date | Thu, 3 Jun 2004 18:39:45 +0200 (CEST) | From | Tim Schmielau <> | Subject | Re: 2.6.7-rc2-mm2 |
| |
> +bsd-acct-warning-fix.patch > > Fix warning in the BSD accounting patch
Thanks for educating me one this.
I vaguely remember someone wrote on lkml that defining variables in blocks was bad because some gcc version wouldn't deal well with it. This was just at the time I wrote these lines, so I refrained from it in spite of the warning. OTOH, this is so very basic C that I cannot imagine gcc getting it wrong.
There is one other mistake in the BSD accounting patch, fixed below (thanks to Peter Lundkvist for reporting).
Then there's the thing with units of time not exactly corresponding to USER_HZ anymore.
And it seems this didn't get much outside testing yet, since I've only recently seen the first download of the userspace tools. Well, BSD accounting isn't too exciting these days...
I'll probably roll up another version before this can hit mainline.
Tim
--- linux-2.6.7-rc2-acct1/include/linux/acct.h 2004-06-03 18:21:47.000000000 +0200 +++ linux-2.6.7-rc2-acct2/include/linux/acct.h 2004-06-03 18:21:55.000000000 +0200 @@ -165,7 +165,7 @@ static inline u64 jiffies_64_to_AHZ(u64 { #if HZ == AHZ /* do nothing */ -#elseif (HZ % AHZ)==0 +#elif (HZ % AHZ)==0 do_div(x, HZ / AHZ); #else x *= AHZ; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |