lkml.org 
[lkml]   [2004]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] serio.c: dynamically control serio ports bindings via procfs (Was: [RFC/RFT] Raw access to serio ports)
Date
On Thursday 03 June 2004 12:54 am, Sau Dan Lee wrote:
> >>>>> "Dmitry" == Dmitry Torokhov <dtor_core@ameritech.net> writes:
>
> Dmitry> Let me start with saying that this is a very good patch
> Dmitry> and that is exactly what I have in mind with regard to
> Dmitry> serio port/device binding. The only problem with the
> Dmitry> patch is that it uses wrong foundation, namely procfs,
> Dmitry> because:
> ...
>
> Dmitry> So we have several options - if we adopt procfs based
> Dmitry> solution now we will have to maintain it for very long
> Dmitry> time, along with competing sysfs implementation. Dropping
> Dmitry> one kernel parameter which will never be widely used is
> Dmitry> much easier, IMO.
>
> It's not just the matter of dropping one kernel parameter. The procfs
> support, _already implemented_, allows one to fine-tune the binding
> between serio ports and devices, which is a new and useful feature
> that your kernel parameter doesn't provide.

What I was trying to say is serio and input system will have sysfs support,
there is no question about that because sysfs _is_ the new driver model. So
by adopting procfs based solution we'll get ourselves 2 competing interfaces
for the same thing, just one will be very limited.

>
> Can you unbind the keyboard port? Can you bind/unbind any of the AUX
> ports *dynamically* without reloading the i8042 module? These

No, and I was not trying to. It is just a stop-gap measure to help end
users to get their PS/2 devices working until we have proper infrastructure
in place.

> functionalities are already there in the serio-related code. Just a
> userland interface is missing. My patch is to fill this gap.
>
>
>
> Dmitry> So I propose we all join our ranks and tame that sysfs
> Dmitry> together ;) I had some patches that were converting
> Dmitry> drivers to the sysfs adding them to serio bus,
>
> sysfs looks good for simple parameters: integers, strings. For
> anything more complicated (sets, graphs), I don't see it fit (yet).
> Unfortunately, the serio port<-->device relation is already a graph (1
> to n).
>
> I'd like to see how you implement the device<-->handler binding in
> input.c using sysfs.

Sysfs provides all the same features as procfs (I mean you write read/write
methods and have them do whatever you please) but it also has benefits of
your stuff integrating with the rest of devices into a hierarchy.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.061 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site