lkml.org 
[lkml]   [2004]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix the cpumask rewrite


On Sat, 26 Jun 2004, James Bottomley wrote:
>
> On Sat, 2004-06-26 at 11:32, Linus Torvalds wrote:
> > Why not? The thing is, the bitmap operators are supposed to work on
> > volatile data, ie people are literally using them for things like
> >
> > while (test_bit(TASKLET_STATE_SCHED, &t->state));
> >
> > and the thing is supposed to work.
>
> Well, I agree it's supposed to work, what I don't agree about is that
> generic code gets to designate critical data as volatile.

I agree in the sense that I don't think the _data_ should be volatile.

But I think the functions to access various pieces of data should be able
to take volatiles without warning.

See the difference? Same way "memcpy()" takes a "const" argument for the
source. That doesn't mean that the source _has_ to be const, it just means
that it won't complain if it is.

And the same is true of "volatile" for the bitop functions. They are
volatile not because they require the data to be volatile, but because
they have at least traditionally been used for various cases, _including_
volatile.

Now, we could say that we don't do that any more, and decide that the
regular bitop functions really cannot be used on volatile stuff. But
that's a BIG decision. And it's certainly not a decision that parisc
users should make.

> Our current set bit functions are *coded* to operate on volatile data,
> we just don't use the volatile keyword to persuade gcc to generate
> better code.

Well, at least judging by your "test_bit()", the function literally is
_not_ coded to work with volatile data.

If the above loop had been a real case, gcc on parisc would have optimized
it away, and done the wrong thing.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.124 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site