Messages in this thread | | | Date | Sat, 26 Jun 2004 09:05:57 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: 2.6.7-bk: asm/setup.h and linux/init.h |
| |
On Sat, 26 Jun 2004, Russell King wrote: > > Is there a reason why we can't delete asm/setup.h from linux/init.h > and change that declaration to: > > +extern char saved_command_line[];
Yes. A number of achitectures use something like
strlcpy(saved_command_line, cmd_line, sizeof(saved_command_line));
and that "sizeof()" would require the full declaration.
However, I don't see any reason why we couldn't make that sizeof be COMMAND_LINE_SIZE instead, if somebody is willing to grep and do the conversion and make sure everybody who now uses it has <asm/setup.h> included.
Hmm?
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |