Messages in this thread | | | Date | Sat, 26 Jun 2004 16:24:29 -0700 | From | Paul Jackson <> | Subject | Re: 2.6.7-bk: asm/setup.h and linux/init.h |
| |
Could someone speak a few words on why a patch such as this is desirable?
Apparently, there is more value to avoiding non-essential include's than I realize. I'd have preferred doing a memcpy of "sizeof(some_struct)" over doing it for SOME_STRUCT_SIZE constant, and I'd have thought it appropriate to include whatever header files were needed to do that.
The simple "wc -l" size of the kernel source goes up a couple of lines, the code complexity is unchanged, and the generated code is unchanged. So obviously none of those factors motivate this change.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.650.933.1373 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |