Messages in this thread | | | Date | Sun, 27 Jun 2004 00:54:35 +0200 | From | Andries Brouwer <> | Subject | Re: drivers/block/ub.c |
| |
On Sat, Jun 26, 2004 at 10:35:15PM +0200, Oliver Neukum wrote:
> > + cmd->cdb[2] = block >> 24; > > + cmd->cdb[3] = block >> 16; > > + cmd->cdb[4] = block >> 8; > > + cmd->cdb[5] = block; > > we have macros for that. > > > + cmd->cdb[7] = nblks >> 8; > > + cmd->cdb[8] = nblks; > > dito
Yes, we have macros. Using those macros would not at all be an improvement here.
Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |