lkml.org 
[lkml]   [2004]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.6.6 buffer.c: bio_alloc() check
On Wed, Jun 02 2004, Yury Umanets wrote:
> [PATCH] 2.6.6 buffer.c: adds bio_alloc() check and error handling in
> fs/buffer.c.
>
> Signed-off-by: Yury Umanets <torque@ukrpost.net>
>
> buffer.c | 25 +++++++++++++++++++++++++
> 1 files changed, 25 insertions(+)
>
> diff -rupN ./linux-2.6.6/fs/buffer.c ./linux-2.6.6-modified/fs/buffer.c
> --- ./linux-2.6.6/fs/buffer.c Mon May 10 05:32:38 2004
> +++ ./linux-2.6.6-modified/fs/buffer.c Wed Jun 2 15:21:47 2004
> @@ -2712,6 +2712,31 @@ void submit_bh(int rw, struct buffer_hea
> * submit_bio -> generic_make_request may further map this bio around
> */
> bio = bio_alloc(GFP_NOIO, 1);
> + if (bio == NULL) {

This is wrong, bio_alloc() never fails if it's called with __GFP_WAIT in
the gfp mask.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.119 / U:2.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site