Messages in this thread | | | Date | Sat, 19 Jun 2004 11:07:14 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2.6.7 and 2.4.27-pre6] new device support for forcedeth.c |
| |
On Sat, Jun 19, 2004 at 12:13:14AM -0700, Brian Lazara wrote: > +#ifndef free_netdev > +#define free_netdev(dev) kfree(dev); > +#endif
free_netdev isn't a macro in 2.6, so you're going to blow up nicely.
> +#define PCI_DEVICE_ID_NVIDIA_NVENET_1 0x01C3 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_2 0x0066 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_3 0x00D6 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_4 0x0086 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_5 0x008C > +#define PCI_DEVICE_ID_NVIDIA_NVENET_6 0x00E6 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_7 0x00DF > +#define PCI_DEVICE_ID_NVIDIA_NVENET_8 0x0056 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_9 0x0057 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_10 0x0037 > +#define PCI_DEVICE_ID_NVIDIA_NVENET_11 0x0038
The go to include/linux/pci_ids.h
> + * Function pointers based on descriptor version > + */ > +int (*nv_alloc_rx)(struct net_device *dev); > +int (*nv_start_xmit)(struct sk_buff *skb, struct net_device *dev); > +void (*nv_tx_done)(struct net_device *dev); > +void (*nv_rx_process)(struct net_device *dev);
Better to put them into the per-device data structures or you're screwed if you have two of those in a system (and even if that's totally impossible global variables like that are still bad style.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |