lkml.org 
[lkml]   [2004]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: make checkstack on m68k
On Fri, 18 June 2004 01:17:31 +1000, Finn Thain wrote:
> To: Andreas Schwab <schwab@suse.de>
> cc: Geert Uytterhoeven <geert@linux-m68k.org>,
> Linux/m68k <linux-m68k@lists.linux-m68k.org>,
> Linux Kernel Development <linux-kernel@vger.kernel.org>

Could you *please* *not* shorten the CC list? Looks like I'm the
checkstack maintainer, so I like to read your comments. Especially,
since they are useful ;)

> On Thu, 17 Jun 2004, Andreas Schwab wrote:
> >
> > $re = qr/.*(?:linkw %fp,|addw )#-([0-9]{1,4})(?:,%sp)?$/o;
>
> I think that should be addaw, not addw. And it may be necessary to remove
> the $ anchor at the end.

Changed, updated patch below. Thanks.

Can anyone test?

Jörn

--
Don't patch bad code, rewrite it.
-- Kernigham and Pike, according to Rusty


checkstack.pl | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
--- linux-2.6.7cow/scripts/checkstack.pl~cs_m68k 2004-06-17 14:58:25.000000000 +0200
+++ linux-2.6.7cow/scripts/checkstack.pl 2004-06-17 20:25:30.000000000 +0200
@@ -40,6 +40,10 @@
} elsif ($arch =~ /^ia64$/) {
#e0000000044011fc: 01 0f fc 8c adds r12=-384,r12
$re = qr/.*adds.*r12=-(([0-9]{2}|[3-9])[0-9]{2}),r12/o;
+ } elsif ($arch =~ /^m68k$/) {
+ #2b6c: 4e56 fb70 linkw %fp,#-1168
+ #1df770: defc ffe4 addaw #-28,%sp
+ $re = qr/.*(?:linkw %fp,|addaw )#-[0-9]{1,4}(?:,%sp)?/o;
} elsif ($arch =~ /^mips64$/) {
#8800402c: 67bdfff0 daddiu sp,sp,-16
$re = qr/.*daddiu.*sp,sp,-(([0-9]{2}|[3-9])[0-9]{2})/o;
@@ -76,7 +80,7 @@
$func = $1;
}
if ($line =~ m/$re/) {
- my $size = $1;
+ my $size = $2;
$size = hex($size) if ($size =~ /^0x/);

if ($size > 0x80000000) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:03    [from the cache]
©2003-2011 Jasper Spaans