lkml.org 
[lkml]   [2004]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix ppc64 out_be64

Hi,

> Ugh ? The syntax of std is std rS, ds(rA), so your fix doesn't look
> good to me, and it definitely builds with the current syntax, though I
> agree the type is indeed wrong. I also spotted another bug where we
> forgot to change an eieio into sync in there though.
>
> Does this totally untested patch works for you ?

It would be nice to make val unsigned long too :)

Anton

> @@ -358,7 +358,7 @@
>
> static inline void out_be64(volatile unsigned long *addr, int val)
> {
> - __asm__ __volatile__("std %1,0(%0); sync" : "=m" (*addr) : "r" (val));
> + __asm__ __volatile__("std%U0%X0 %1,%0; sync" : "=m" (*addr) : "r" (val));
> }
>
> #ifndef CONFIG_PPC_ISERIES
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.051 / U:1.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site