Messages in this thread | | | Date | Fri, 11 Jun 2004 11:48:44 +0200 | From | Pavel Machek <> | Subject | Re: Fix memory leak in swsusp |
| |
Hi!
> > > > @@ -803,32 +804,31 @@ > > > > return 0; > > > > } > > > > > > > > + err = -ENOMEM; > > > > while ((m = (void *) __get_free_pages(GFP_ATOMIC, pagedir_order))) { > > > > memset(m, 0, PAGE_SIZE); > > > > > > BTW, what does this memset do? > > > > Here's incremental fix, it compiles but not tested. > > Thanks, but my question remains: why do we need the memset? The > area allocated is either thrown away because it collides or is > overwritten with the pagedir stuff straight away.
You are right, it should not be needed. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |