Messages in this thread | | | Date | Fri, 11 Jun 2004 16:19:20 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] Permit inode & dentry hash tables to be allocated > MAX_ORDER size |
| |
"Martin J. Bligh" <mbligh@aracnet.com> wrote: > > We've hit a problem with alignment issues where the start of the zone is > aligned to 16MB, for instance, and the max grouping is now 256MB. That > generatates a "warning: wrong zone alignment: it will crash" error (or > something similar). Andy sent me a patch this morning to throw away > the lower section, which is much nicer than crashing ... but I'd prefer > not to throw that RAM away unless we have to.
Confused. Why do we have that test in there at all? We should just toss the pages one at a time into the buddy list and let the normal coalescing work it out. That way we'd end up with a single 16MB "page" followed by N 256MB "pages".
> Allocating the big-assed hashes out of bootmem seems much cleaner to me, > at least ...
Maybe. That code seems fragile and I have premonitions of unhappy arch maintainers. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |