lkml.org 
[lkml]   [2004]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] IDE update for 2.6.7-rc3 [11/12]
    Date
    On Friday 11 of June 2004 19:01, Jens Axboe wrote:
    > On Fri, Jun 11 2004, Bartlomiej Zolnierkiewicz wrote:
    > > [PATCH] ide: kill task_[un]map_rq()
    > >
    > > PIO handlers under CONFIG_IDE_TASKFILE_IO=n are never used for bio
    > > based requests (rq->bio is always NULL) so we can use rq->buffer
    > > directly instead of calling ide_[un]map_buffer().
    >
    > Not so sure if it's ever used for something requiring performance, and
    > even if it isn't then it may still be worth it to keep the mapping and
    > instead fix the task setup to map in user data with blk_rq_map_user() by
    > fixing up ide_taskfile_ioctl().

    I agree about blk_rq_map_user() (I even did it once around 2.5.60-70).
    However I think that we are better off (slowly) killing old taskfile
    handlers completely (this patch is for old taskfile handlers only)
    and using CONFIG_IDE_TASKFILE_IO versions (which know about rq->bio).

    > It would make HDIO_DRIVE_TASKFILE a whole lot nicer.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.021 / U:0.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site