Messages in this thread | | | Date | Fri, 11 Jun 2004 18:46:00 +0200 | From | Luca Risolia <> | Subject | Re: [linux-usb-devel] Re: Finding user/kernel pointer bugs [no html] |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Fri, 11 Jun 2004 09:17:48 -0700 Greg KH <greg@kroah.com> wrote:
> On Fri, Jun 11, 2004 at 06:31:07AM +0200, Luca Risolia wrote: > > > unsigned int cmd, void* arg) > > > { > > > struct w9968cf_device* cam; > > > + void __user *user_arg = (void __user *)arg; > > > > The right place to apply this patch is in video_usercopy(). > > Um, the driver you just refered to does not use the video_usercopy() > function so your email doesn't make much sense in this context.
Oops, sorry. I forgot the w9968cf doesn't actually use video_usercopy(). However, apart from the "__user" context, there are several drivers under drivers/usb/media/ that still use that usercopy() thing.
> > > Please have a look at definition of the function in videodev.c. > > Please excuse me while I go get sick... > > Anyway, that function needs to be properly marked up with __user if you > want it to live. > > good luck, > > greg k-h > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFAyeHImdpdKvzmNaQRAgSbAJ9J+Zq4PsS59Z0muH1nJM036CCBzACglYQO 5/kAGoFHru+NpJ0/wNd0YT0= =57yE -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |