[lkml]   [2004]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
On Wed. June 09, 2004 William Lee Irwin III wrote:
> The MSI writers have a lot to answer for. Could you test this?

Hi William,

The MSI patch has existed in the kernel since 2.6.3 and has been
validated in both UP and SMP environments. It appears another patch
(don't know which one) redefined the value of TARGET_CPU, which is
used by the function msi_address_init() to configure logical
target CPU. The redefinition of TARGET_CPU without checking its
usage by other kernel code broke the build.

Your patch fixes the build but breaks the devices using MSI in
different architectures supported by the function msi_address_init().
I have attached a patch that fixes the build and maintains cross
architecture support for MSI.


diff -urN linux-2.6.7-rc3-mm1/include/asm-i386/msi.h 2.6.7-rc3-mm1-fix/include/asm-i386/msi.h
--- linux-2.6.7-rc3-mm1/include/asm-i386/msi.h 2004-05-09 22:32:52.000000000 -0400
+++ 2.6.7-rc3-mm1-fix/include/asm-i386/msi.h 2004-06-09 17:21:07.000000000 -0400
@@ -16,7 +16,7 @@
#define MSI_TARGET_CPU logical_smp_processor_id()
+#define MSI_TARGET_CPU cpu_to_logical_apicid(first_cpu(cpu_online_map))

#endif /* ASM_MSI_H */
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at
 \ /
  Last update: 2005-03-22 14:03    [W:0.054 / U:11.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site