lkml.org 
[lkml]   [2004]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.7-rc2 mismatched preempt count in arch/i386/kernel/irq.c
On Mon, 31 May 2004, Keith Owens wrote:

> 2.6.7-rc2 (and earlier) arch/i386/kernel/irq.c::do_IRQ() calls
> irq_exit() which expands into preempt_enable_no_resched(), amongst
> others. With CONFIG_PREEMPT=y, preempt_enable_no_resched() does
> dec_preempt_count(). Where is the corresponding inc_preempt_count?
> AFAICT the use of preempt_enable_no_resched() is unbalanced.

I believe IRQ_EXIT_OFFSET takes care of that;

#define IRQ_EXIT_OFFSET (HARDIRQ_OFFSET-1)

#define irq_exit() \
do { \
preempt_count() -= IRQ_EXIT_OFFSET; \
if (!in_interrupt() && softirq_pending(smp_processor_id())) \
do_softirq(); \
preempt_enable_no_resched(); \
} while (0)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:03    [from the cache]
©2003-2011 Jasper Spaans