lkml.org 
[lkml]   [2004]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: 2.6.6-rc3-mm1
    ==> Regarding Re: 2.6.6-rc3-mm1; raven@themaw.net adds:

    raven> The case where two process similtaneously trigger a mount in autofs4
    raven> can cause multiple requests to the daemon for the same mount. The
    raven> daemon handles this OK but it's possible an incorrect error to be
    raven> returned. For this reason I believe it is better to change the spin
    raven> lock to a semaphore in waitq.c. This makes the second and subsequent
    raven> request wait on the q as ther supposed to.

    This looks good to me. Do you also need to take the semaphore in
    autofs4_catatonic_mode(), around the hijacking of the queue?

    void autofs4_catatonic_mode(struct autofs_sb_info *sbi)
    {
    struct autofs_wait_queue *wq, *nwq;

    DPRINTK(("autofs: entering catatonic mode\n"));

    sbi->catatonic = 1;
    wq = sbi->queues;
    sbi->queues = NULL; /* Erase all wait queues */
    ...


    -Jeff
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.022 / U:2.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site