[lkml]   [2004]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH][RFC] 2.6.6 tty_io.c hangup locking
    Paul Fulghum <> wrote:
    > The following patch removes unnecessary disabling of
    > interrupts when processing hangup for tty devices.

    Ho hum, this has been hanging around forever. Obviously the current
    locking is pointless and the only useful locking we have in there is

    The reason why a patch such as yours wasn't applied is that it was all kept
    as a reminder that we suck. Someone needs to get down and audit what's
    actually happening in there. It seems that you've now done that via
    comparison with other callers, but that is not necessarily a good approach
    when it comes to the tty layer ;)

    We need to itemise all the affected memory storage in all impementations of
    ->flush_buffer() and ->write_wakeup() and then make sure that all _other_
    users of those fields (whether or not they lie in the ->flush_buffer() and
    ->write_wakeup() codepaths) are using the same locking. Is that something
    you could do?
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:03    [W:0.021 / U:322.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site