Messages in this thread | | | Date | Wed, 26 May 2004 16:26:07 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] SMP support for drain local pages v2. |
| |
Nigel Cunningham <ncunningham@linuxmail.org> wrote: > > +/* > + * Spill per-cpu pages on all CPUs back into the buddy allocator. > + * The first function is just to avoid a compiler warning. > + */ > +static void __smp_drain_local_pages(void * data) > +{ > + drain_local_pages(); > +} > + > +void smp_drain_local_pages(void) > +{ > + on_each_cpu(__smp_drain_local_pages, NULL, 0, 1); > +}
I think we only need a single entry point. Make it a new "drain_percpu_pages()" or such to break unconverted callers, switch callers of drain_local_pages() over to the new function. It needs no SMP ifdefs in it - on_each_cpu() will do the right thing on UP.
But until something which needs this change is merged into the tree I'd say that this patch should live with the patch which requires it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |