lkml.org 
[lkml]   [2004]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: swsusp: fix swsusp with intel-agp
Hi!

> > > >
> > > > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > > > + {
> > > > + extern char swsusp_pg_dir[PAGE_SIZE];
> > > > + memcpy(swsusp_pg_dir, swapper_pg_dir, PAGE_SIZE);
> > > > + }
> > > > +#endif
> > >
> > > Please move the declaration of swsusp_pg_dir[] to a header file where it is
> > > visible to both the users and the definition site, then resend.
> >
> > Hmm, on second thought, it is accessed from one C file and once from
> > assembly => prototype should not be needed.
> >
> > Upon popular request I made it depend on CONFIG_PM (pmdisk will need
> > it, too, and suspend2 wants it also). If you don't like that please
> > simply replace CONFIG_PM with CONFIG_SOFTWARE_SUSPEND...
>
> Mabe it's a sign of advancing years, but I still think that 4k is worth
> saving ;) I ended up with the below.

Ok, thanks ;-).

> You say that pmdisk needs this. I assume that means that we should also
> replace swapper_pg_dir with swsusp_pg_dir in pmdisk.S?

Yes, that should do the trick.
Pavel
--
934a471f20d6580d5aad759bf0d97ddc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [from the cache]
©2003-2011 Jasper Spaans