Messages in this thread | | | Subject | Re: [patch] bug in cpuid & msr on nosmp machine | From | Andi Kleen <> | Date | Sat, 22 May 2004 10:13:01 +0200 |
| |
Andrew Morton <akpm@osdl.org> writes:
> Rusty Russell <rusty@rustcorp.com.au> wrote: >> >> On Thu, 2004-05-20 at 17:32, Andrew Morton wrote: >> > I think what you want here is >> > >> > if (!cpu_possible(cpu) || !cpu_online(cpu)) >> > return -ENXIO; >> >> It works, but it's not really correct. cpu_possible() is correct, but >> cpu_online() might no longer be true by the time do_cpu_read() calls >> do_cpu_id(). > > mutter. Are we likely to see any ia32 or x86_64 hotplug-cpu machines?
Yes. Think vmware and virtualization, where partitions could get CPUs added and removed at runtime.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |