lkml.org 
[lkml]   [2004]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: overlaping printk

* Andrew Morton <akpm@osdl.org> wrote:

> Ingo Molnar <mingo@elte.hu> wrote:
> >
> > i've attached a new patch that does what Andi suggested too -
> > timestamping of the oopses. This way we will zap no sooner than 10
> > seconds after the first oops.
>
> I think that will do the wrong thing between 23 and 47 days uptime
> because time_after() will return an incorrect answer.
>
> How's this look?

> + static unsigned long oops_timestamp;
> +
> + if (time_after_eq(jiffies, oops_timestamp) &&
> + !time_after(jiffies, oops_timestamp + 30*HZ))
> return;
> +

looks good to me!

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [from the cache]
©2003-2011 Jasper Spaans