lkml.org 
[lkml]   [2004]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [linux-usb-devel] [BK PATCH] USB changes for 2.6.6
    On Sat, May 15, 2004 at 10:37:10AM -0700, Linus Torvalds wrote:
    > Replace all "led" with "cytherm". The code was crap, and would never have
    > compiled with debugging on anyway.

    I fixed my crappy code. :)
    diff -urN linux-2.6.6/drivers/usb/misc/cytherm.c linux-2.6.6-cytherm/drivers/usb/misc/cytherm.c
    --- linux-2.6.6/drivers/usb/misc/cytherm.c 2004-05-10 04:33:19.000000000 +0200
    +++ linux-2.6.6-cytherm/drivers/usb/misc/cytherm.c 2004-05-19 22:23:58.000000000 +0200
    @@ -122,12 +122,12 @@
    retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS,
    cytherm->brightness, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
    /* Inform µC that we have changed the brightness setting */
    retval = vendor_command(cytherm->udev, WRITE_RAM, BRIGHTNESS_SEM,
    0x01, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);

    kfree(buffer);

    @@ -161,13 +161,13 @@
    /* read temperature */
    retval = vendor_command(cytherm->udev, READ_RAM, TEMP, 0, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
    temp = buffer[1];

    /* read sign */
    retval = vendor_command(cytherm->udev, READ_RAM, SIGN, 0, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);
    sign = buffer[1];

    kfree(buffer);
    @@ -205,7 +205,7 @@
    /* check button */
    retval = vendor_command(cytherm->udev, READ_RAM, BUTTON, 0, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);

    retval = buffer[1];

    @@ -242,7 +242,7 @@

    retval = vendor_command(cytherm->udev, READ_PORT, 0, 0, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);

    retval = buffer[1];

    @@ -277,7 +277,7 @@
    retval = vendor_command(cytherm->udev, WRITE_PORT, 0,
    tmp, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);

    kfree(buffer);

    @@ -302,7 +302,7 @@

    retval = vendor_command(cytherm->udev, READ_PORT, 1, 0, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);

    retval = buffer[1];

    @@ -337,7 +337,7 @@
    retval = vendor_command(cytherm->udev, WRITE_PORT, 1,
    tmp, buffer, 8);
    if (retval)
    - dev_dbg(&led->udev->dev, "retval = %d\n", retval);
    + dev_dbg(&cytherm->udev->dev, "retval = %d\n", retval);

    kfree(buffer);
    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.023 / U:124.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site