Messages in this thread | | | Date | Tue, 18 May 2004 17:38:45 -0700 | From | Andrew Morton <> | Subject | Re: vga16fb broke |
| |
James Simmons <jsimmons@infradead.org> wrote: > > > > I have pondered your email at length and have failed to understand it. > > > > I _think_ you're saying that we need to do this, which will fix x86: > > > > --- 25/drivers/video/vga16fb.c~vga16fb-fix Tue May 18 17:10:14 2004 > > +++ 25-akpm/drivers/video/vga16fb.c Tue May 18 17:10:39 2004 > > @@ -1347,7 +1347,7 @@ int __init vga16fb_init(void) > > > > /* XXX share VGA_FB_PHYS and I/O region with vgacon and others */ > > > > - vga16fb.screen_base = ioremap(VGA_MAP_MEM(VGA_FB_PHYS), VGA_FB_PHYS_LEN); > > + vga16fb.screen_base = VGA_MAP_MEM(VGA_FB_PHYS); > > if (!vga16fb.screen_base) { > > printk(KERN_ERR "vga16fb: unable to map device\n"); > > ret = -ENOMEM; > > This will make the driver on all platforms.
There's a missing word in that sentence. Was it "work" or "crash"? This matters ;)
> _ > > > > and that ARM and others need to teach their VGA_MAP_MEM() to do an internal > > ioremap(). > > > > Or do you mean something else? Please be more clear? > > I like to see the VGA_MAP_MEM hack go away and be replaced with ioremap.
If you can cut a patch we can ask arch maintainers to review and test it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |