Messages in this thread Patch in this message | | | Date | Mon, 17 May 2004 13:46:51 +0200 | From | Andi Kleen <> | Subject | Re: i810 AGP fails to initialise (was Re: 2.6.6-mm2) |
| |
On Mon, 17 May 2004 12:04:36 +0100 Sean Neakums <sneakums@zork.net> wrote:
> Andi Kleen <ak@suse.de> writes: > > > On Mon, May 17, 2004 at 09:49:56AM +0100, Sean Neakums wrote: > >> Sean Neakums <sneakums@zork.net> writes: > >> > >> > Sean Neakums <sneakums@zork.net> writes: > >> > > >> >> Andi Kleen <ak@suse.de> writes: > >> >> > >> >>> Sean, can you double check that when you compile the AGP driver as module > >> >>> that the 7124 PCI ID appears in modinfo intel-agp ? > >> >>> And does the module also refuse to load ? > >> >> > >> >> I rebuilt with agpgart, intel-agp and i810 as modules, modprobed them, > >> >> and it works. > >> > > >> > I just realised that I probably forgot to reapply the patch before > >> > doing this test. Will check Monday. Sorry about this. > >> > >> Below is modinfo output. The module loads but doesn't initialise the > >> AGP. > > > > Someone else reported that it worked modular at least. When you apply > > the following patch what output do you get in the kernel log when you > > load the module? > > Linux agpgart interface v0.100 (c) Dave Jones > agp_intel_init > agp_intel_probe device 7124 > no cap
Thanks for testing.
Ok. This patch should fix it then. Revert the debug patch first. Apparently some of the devices listed don't have a AGP capability. Maybe they're only AGPv1 compliant?
Dave, please apply.
-Andi
--- linux-2.6.6-work/drivers/char/agp/intel-agp.c.~3~ 2004-05-17 13:45:26.000000000 +0200 +++ linux-2.6.6-work/drivers/char/agp/intel-agp.c 2004-05-17 13:46:15.000000000 +0200 @@ -1264,8 +1264,6 @@ struct resource *r; cap_ptr = pci_find_capability(pdev, PCI_CAP_ID_AGP); - if (!cap_ptr) - return -ENODEV; bridge = agp_alloc_bridge(); if (!bridge) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |