Messages in this thread | | | Date | Sat, 15 May 2004 18:23:04 -0400 | From | Jeff Garzik <> | Subject | Re: [RFC][DOC] writing IDE driver guidelines |
| |
Bartlomiej Zolnierkiewicz wrote: > On Saturday 15 of May 2004 19:34, Jeff Garzik wrote: >>On Sat, May 15, 2004 at 07:23:50PM +0200, Bartlomiej Zolnierkiewicz wrote: >>>- host drivers should request/release IO resource >>> themelves and set hwif->mmio to 2 >> >>Don't you mean, hwif->mmio==2 for MMIO hardware? > > > It is was historically for MMIO, now it means that driver > handles IO resource itself (per comment in <linux/ide.h>).
Maybe then create a constant HOST_IO_RESOURCES (value==2) to make that more obvious?
>>>- define ide_default_irq(), ide_init_default_irq() >>> and ide_default_io_base() to (0) >> >>Maybe provide generic definitions, so that new arches don't even >>have to care about this? > > > Please explain.
Your document appears to imply that each new arch should define the above three symbols.
My suggestion is to devise a method by which new arches don't have to care about those symbols at all, unless required to do so by the underlying hardware.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |