Messages in this thread | | | Date | Thu, 13 May 2004 11:05:17 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: More convenient way to grab hugepage memory |
| |
On Thu, May 13, 2004 at 12:13:59AM -0700, William Lee Irwin III wrote: > On Thu, 2004-05-13 at 16:59, William Lee Irwin III wrote: > >> Atop my other patch to nuke the unused global variables, here is a patch > >> to manually inline __do_mmap_pgoff(), removing the inline usage. Untested. > >> Are you sure you want this? #ifdef'ing out the hugetlb case is somewhat > >> more digestible with the inline in place, e.g.: > > On Thu, May 13, 2004 at 05:09:01PM +1000, Benjamin Herrenschmidt wrote: > > Well, I did the breakup in 2 pieces in the first place for 2 reasons: > > - the original patch had some subtle issues with accounting > > - do_mmap_pgoff is already such a mess, let's not make it worse > > I mean, it's awful to get anything right in this function, especially > > the cleanup/exit path, which is why I think it's more maintainable > > cut in 2. > > Well, writing it vaguely convinced me that it wasn't a great idea; I > suppose now that Muli can look at the result he'll be convinced > likewise.
No need to convince me; my comment was strictly with regards to inlining the function (as opposed to just leaving it static), not with regards to splitting up the messy horror that is do_mmap_pgoff, which I am very much in favor of.
Cheers, Muli -- Muli Ben-Yehuda http://www.mulix.org | http://mulix.livejournal.com/
[unhandled content-type:application/pgp-signature] | |