Messages in this thread | | | Subject | Re: [4KSTACK][2.6.6] Stack overflow in radeonfb | From | Benjamin Herrenschmidt <> | Date | Fri, 14 May 2004 08:56:21 +1000 |
| |
> --- linux-2.6/drivers/video/aty/radeon_base.c~ 2004-05-13 16:51:08.000000000 +0200 > +++ linux-2.6/drivers/video/aty/radeon_base.c 2004-05-13 16:55:09.000000000 +0200 > @@ -1397,7 +1397,7 @@ > { > struct radeonfb_info *rinfo = info->par; > struct fb_var_screeninfo *mode = &info->var; > - struct radeon_regs newmode; > + static struct radeon_regs newmode; > int hTotal, vTotal, hSyncStart, hSyncEnd, > hSyncPol, vSyncStart, vSyncEnd, vSyncPol, cSync; > u8 hsync_adj_tab[] = {0, 0x12, 9, 9, 6, 5}; > > I'm not sure what the point behind the radeon_write_mode() is at all. > The best solution could be to just merge radeon_write_mode() and > radeonfb_set_par() into a single function and do the tons of OUTREG() > directly. In that case, don't bother to fix any typos
No, they should stay separate functions. I may use write_mode in a different way in the future (like restoring previous mode on module unload for example) and I'm very much against merging 2 already too big function into one huge horror.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |