lkml.org 
[lkml]   [2004]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] [PATCH] Performance of del_timer_sync

    * Andrew Morton <akpm@osdl.org> wrote:

    > Ingo, why is this not sufficient?
    >
    > @@ -331,6 +331,8 @@ int del_timer_sync(struct timer_list *ti
    >
    > del_again:
    > ret += del_timer(timer);
    > + if (!ret)
    > + return 0;
    >
    > for_each_cpu(i) {
    > base = &per_cpu(tvec_bases, i);

    it's not sufficient because a timer might be running on another CPU even
    if it has not been deleted. We delete a timer prior running it (so that
    the timer fn can re-activate the timer). So del_timer_sync() has to
    synchronize independently of whether the timer was removed or not.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:03    [W:0.021 / U:0.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site