Messages in this thread | | | From | "Miquel van Smoorenburg" <> | Subject | Re: dd PATCH: add conv=direct | Date | Thu, 8 Apr 2004 11:44:59 +0000 (UTC) |
| |
In article <20040407220928.GI2814@hexapodia.org>, Andy Isaacson <adi@hexapodia.org> wrote: >On Wed, Apr 07, 2004 at 05:02:24PM -0500, Nathan Straz wrote: >> On Tue, Apr 06, 2004 at 05:03:58PM -0500, Andy Isaacson wrote: >> > Linux-kernel: is this patch horribly wrong? >> ... >> > to force O_DIRECT. The enclosed patch adds a "conv=direct" flag to >> > enable this usage. >> >> Adding the functionality to conv= doesn't seem right to me. conv= is >> for converting the data in some way. This is just changing the way data >> is written. Right? > >There's already conv=notrunc which means "open without O_TRUNC". I >agree that it's a nonintuitive interface, but then, the entire dd(1) >command line is.
Well as you already added iflags and oflags, it makes more sense to use those. oflags=fsync makes more sense to me than conv=fsync. Likewise oflags=notrunc.
Mike.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |