lkml.org 
[lkml]   [2004]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Lhms-devel] [patch 4/6] memory hotplug for hugetlbpages
On Tue, Apr 06, 2004 at 09:48:01PM +0900, Hirokazu Takahashi wrote:
> @@ -1667,6 +1670,7 @@ int handle_mm_fault(struct mm_struct *mm
> pmd_t fastcall *__pmd_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address)
> {
> pmd_t *new;
> + struct page *page;
>
> spin_unlock(&mm->page_table_lock);
> new = pmd_alloc_one(mm, address);
> @@ -1682,6 +1686,8 @@ pmd_t fastcall *__pmd_alloc(struct mm_st
> pmd_free(new);
> goto out;
> }
> + page = virt_to_page(new);
> + pmd_add_rmap(new, mm, address);

Doesn't this want to be:

pmd_add_rmap(page, mm, address);

?

And how about collapsing this down to:

pmd_add_rmap(virt_to_page(new), mm, address);

?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.062 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site