lkml.org 
[lkml]   [2004]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [CHECKER] Transcation is not fully aborted upon failure in JFS (jfs 2.4, kernel 2.4.19)
From
Date
On Tue, 2004-04-27 at 01:54, Junfeng Yang wrote:
> Hi,
>
> We checked JFS filesystem on linux 2.4.19 recently and found 1 case that
> looks like bugs.
>
> When doing jfs_rename, if dtDelete fails, the transaction won't be fully
> aborted (even if txAbort is called).

Looking back at an old version of the code, the original coder had the
kernel trap if dtDelete failed. It really would be a rare case for
dtDelete to fail here. I had changed the trap to the txAbort call to
make the unlikely failure a little more friendly. I recognized that
everything wouldn't be completely consistent, so I had txAbort mark the
superblock dirty, which will force a complete fsck run before the volume
can be mounted again.

I can probably improve on this and leave the system in better
condition. I'll treat this as a low priority bug.

Thanks for your work auditing the code and reporting the problem.
--
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.065 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site