lkml.org 
[lkml]   [2004]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: New warnings on NTFS code
From
Date
On Wed, 2004-04-28 at 09:13, Meelis Roos wrote:
> This is 2.6.6-rc3 on sparc64. It has recently got some new warnings in
> NTFS (there was a warning before but now there are more):
>
> fs/ntfs/super.c: In function `parse_ntfs_boot_sector':
> fs/ntfs/super.c:638: warning: long long unsigned int format, s64 arg (arg 4)

Oops. A missing cast in a printf(). Now fixed in my tree.

> fs/ntfs/super.c: In function `ntfs_fill_super':
> fs/ntfs/super.c:1523: warning: cast to pointer from integer of different size
> fs/ntfs/super.c:1529: warning: cast to pointer from integer of different size
> fs/ntfs/super.c:1634: warning: cast to pointer from integer of different size
>
> The 3 new warnings are because of this definition:
>
> #define OGIN ((struct inode*)le32_to_cpu(0x4e49474f)) /* OGIN */
>
> This seems suspicious - hardcoded pointer?

It is a pointer poison. Now fixed in my tree.

I will submit the fixes with the next NTFS release which should be in a
few weeks. None of the above indicate anything is broken, so there is
no hurry...

Thanks for the report!

Best regards,

Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ &
http://www-stu.christs.cam.ac.uk/~aia21/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.180 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site