lkml.org 
[lkml]   [2004]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch] 2.6.6-rc2 Allow architectures to reenable interrupts on contended spinlocks
    From
    Date

    > +#ifdef __HAVE_ARCH_RAW_SPIN_LOCK_FLAGS
    > +#define _raw_spin_lock(lock) _raw_spin_lock_flags(lock, 0)
    > +#else
    > +#define _raw_spin_lock_flags(lock, flags) do { (void)flags; _raw_spin_lock(lock); } while(0)
    > +#endif

    Looks good, except as paulus noted that using 0 for flags in the
    _raw_spin_lock() case is wrong, since 0 is a valid flags value
    for some archs that could mean anything...

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.018 / U:31.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site