Messages in this thread | | | Date | Thu, 22 Apr 2004 09:58:01 +0200 | From | Vojtech Pavlik <> | Subject | Re: [PATCH 8/15] New set of input patches: atkbd - use bitfields |
| |
On Thu, Apr 22, 2004 at 02:41:11AM -0500, Dmitry Torokhov wrote: > On Thursday 22 April 2004 02:31 am, Vojtech Pavlik wrote: > > On Wed, Apr 21, 2004 at 12:57:51AM -0500, Dmitry Torokhov wrote: > > > > > > =================================================================== > > > > > > > > > ChangeSet@1.1909, 2004-04-20 22:29:12-05:00, dtor_core@ameritech.net > > > Input: remove unneeded fields in atkbd structure, convert to bitfields > > > > I think this is incorrect. We cannot set the bits in bitfields > > atomically, which we need in some cases. We probably need to add > > volatiles to some of them, too. > > > > > > I don't think we have a problem with concurrent access here... One group is set > exclusively in atkbd_interrupt, other one is pretty mich static.
Ok, then. I'll check them one by one anyway.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |