lkml.org 
[lkml]   [2004]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 9/15] New set of input patches: atkbd timeout complaints
On Wed, Apr 21, 2004 at 12:58:42AM -0500, Dmitry Torokhov wrote:
>
> ===================================================================
>
>
> ChangeSet@1.1910, 2004-04-20 22:32:46-05:00, dtor_core@ameritech.net
> Input: Do not generate events from atkbd until keyboard is completely
> initialized. It should suppress messages about suprious NAKs
> when controller's timeout is longer than one in atkbd

We may need to protect ourselves against this - it may confuse the probe
in addition to just generating spurious messages.

>
>
> atkbd.c | 6 ++++++
> 1 files changed, 6 insertions(+)
>
>
> ===================================================================
>
>
>
> diff -Nru a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> --- a/drivers/input/keyboard/atkbd.c Tue Apr 20 23:09:40 2004
> +++ b/drivers/input/keyboard/atkbd.c Tue Apr 20 23:09:40 2004
> @@ -188,6 +188,7 @@
> unsigned int resend:1;
> unsigned int release:1;
> unsigned int bat_xl:1;
> + unsigned int enabled:1;
>
> unsigned int last;
> unsigned long time;
> @@ -248,6 +249,9 @@
> goto out;
> }
>
> + if (!atkbd->enabled)
> + goto out;
> +
> if (atkbd->translated) {
>
> if (atkbd->emul ||
> @@ -749,6 +753,8 @@
> atkbd->set = 2;
> atkbd->id = 0xab00;
> }
> +
> + atkbd->enabled = 1;
>
> if (atkbd->extra) {
> atkbd->dev.ledbit[0] |= BIT(LED_COMPOSE) | BIT(LED_SUSPEND) | BIT(LED_SLEEP) | BIT(LED_MUTE) | BIT(LED_MISC);
>

--
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.154 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site