lkml.org 
[lkml]   [2004]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.6-rc1-mm1
On Wed, 21 Apr 2004, Christoph Hellwig wrote:

> >
> > It is not possible to merge the functionality of may_umount into this as,
> > it stands, as autofs v3 requires a slightly different semantic. That is if
> > there are submounts that are not busy then it should return -EBUSY but
> > may_umount_tree would return not busy.
>
> What about adding a paramter 'ignore_busy_submounts' and use most of the
> function in common for both autofs3 and autofs4?

Thought of that as I was writing the response.
I'll merge the two functions then and produce an updated patch.

>
> > + struct list_head *next;
> > + struct vfsmount *this_parent = mnt;
> > + int actual_refs;
> > + int minimum_refs;
> > +
> > + spin_lock(&vfsmount_lock);
> > + actual_refs = atomic_read(&mnt->mnt_count);
> > + minimum_refs = 2;
> > +repeat:
> > + next = this_parent->mnt_mounts.next;
> > +resume:
> > + while (next != &this_parent->mnt_mounts) {
> > + struct vfsmount *p = list_entry(next, struct vfsmount, mnt_child);
> > +
> > + next = next->next;
>
> Any chance to use list_for_each_entry here?

Same thought occured to me as well. As above.

>
> > + if ( !list_empty(&p->mnt_mounts) ) {
>
> This wants a white-space fixup.

Yes it's not quite the format I like most atm. I'll also do that.

May take a couple of days though.

Thanks for you continuing interest and help.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [from the cache]
©2003-2011 Jasper Spaans