lkml.org 
[lkml]   [2004]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix
    Date
    On Friday 02 April 2004 11:43, Christoph Hellwig wrote:

    Hi Christoph,

    > I got lots of the following OOPSEs with 2.6.5-rc3aa2 on a powerpc running
    > the xfs testsuite (with the truncate fix applied):

    What truncate fix? Sorry if I missed that.

    dunno if the below is causing your trouble, but is that intentional that
    page_cache_release(page) is called twice?

    diff -urNp --exclude CVS --exclude BitKeeper --exclude {arch}
    --exclude .arch-ids 2.6.5-rc3/mm/page_io.c xx/mm/page_io.c
    --- 2.6.5-rc3/mm/page_io.c 2002-12-15 04:18:17.000000000 +0100
    +++ xx/mm/page_io.c 2004-04-02 05:32:57.381688904 +0200
    @@ -161,7 +176,13 @@ int rw_swap_page_sync(int rw, swp_entry_
    ret = swap_writepage(page, &swap_wbc);
    wait_on_page_writeback(page);
    }
    - page->mapping = NULL;
    +
    + lock_page(page);
    + remove_from_page_cache(page);
    + unlock_page(page);
    + page_cache_release(page);
    + page_cache_release(page); /* For add_to_page_cache() */



    ciao, Marc
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:4.563 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site