lkml.org 
[lkml]   [2004]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] more i386 head.S cleanups
    Date
    Followup to:  <406ECAE7.1020407@quark.didntduck.org>
    By author: Brian Gerst <bgerst@didntduck.org>
    In newsgroup: linux.dev.kernel
    >
    > - Move empty_zero_page and swapper_pg_dir to BSS. This requires that
    > BSS is cleared earlier, but reclaims over 3k that was lost due to page
    > alignment.
    > - Move stack_start, ready, and int_msg, boot_gdt_descr, idt_descr, and
    > cpu_gdt_descr to .data. They were interfering with disassembly while in
    > .text.
    >

    Some of them should be in .rodata instead of .data.

    .data should only be used for modifiable numbers.

    All in all these patches are a good idea; I had the same thoughts when
    I was doing the changes to the boot page tables, but didn't want to
    change too much at once.

    -hpa
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:02    [W:0.021 / U:1.956 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site