Messages in this thread | | | Date | Thu, 15 Apr 2004 12:59:33 -0700 | From | David Brownell <> | Subject | Re: [linux-usb-devel] 2.6.6-rc1: cdc-acm still (differently) broken |
| |
Hi Colin,
>>That test has always been buggy -- better to just remove it. For >>that matter, usb_interface_claimed() calls should all vanish ... it's >>better to fail if claiming the interface fails (one step, not two). >>Care to try an updated patch? > > > Like this one? It works. I'm a bit wondering, however, how comes > usb_interface_claimed() returns true, and the check in > usb_driver_claim_interface() passes?
Pretty much like that one, but not leaking the other urbs ... :)
There are two interfaces involved, for "control" and "data". "Control" is being probed; and "data" is what gets claimed.
For more info, you could see how "usbnet" handles CDC Ethernet; see how it parses the CDC Union descriptor (which is what the FIXME refers to). Or read the CDC spec, from www.usb.org as PDF.
- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |