lkml.org 
[lkml]   [2004]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: fix get_wchan() FIXME wrt. order of functions
On Thu, Apr 01, 2004 at 01:55:26AM -0800, William Lee Irwin III wrote:
> This addresses the issue with get_wchan() that the various functions
> acting as scheduling-related primitives are not, in fact, contiguous
> in the text segment. It creates an ELF section for scheduling primitives
> to be placed in, and places currently-detected (i.e. skipped during stack
> decoding) scheduling primitives and others like io_schedule() and down(),
> which are currently missed by get_wchan() code, into this section also.
> The net effects are more reliability of get_wchan()'s results and the
> new ability, made use of by this code, to arbitrarily place scheduling
> primitives in the source code without disturbing get_wchan()'s accuracy.
> Suggestions by Arnd Bergmann and Matthew Wilcox regarding reducing the
> invasiveness of the patch were incorporated during prior rounds of review.
> I've at least tried to sweep all arches in this patch.
> vs. 2.6.5-rc3. Rediffing vs. -mm would be easy for me.

Brown paper bag patch. Should fix the missing relocations you saw.


Index: sched-2.6.5-rc3/arch/i386/kernel/semaphore.c
===================================================================
--- sched-2.6.5-rc3.orig/arch/i386/kernel/semaphore.c 2004-03-31 18:34:02.000000000 -0800
+++ sched-2.6.5-rc3/arch/i386/kernel/semaphore.c 2004-04-01 03:13:48.000000000 -0800
@@ -188,7 +188,7 @@
* value..
*/
asm(
-".section sched.text\n"
+".section .sched.text\n"
".align 4\n"
".globl __down_failed\n"
"__down_failed:\n\t"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:02    [from the cache]
©2003-2011 Jasper Spaans