Messages in this thread Patch in this message | | | Date | Sun, 07 Mar 2004 21:08:15 +0100 | From | Michal Schmidt <> | Subject | Re: Linux 2.4.26-pre2 |
| |
Hello,
> <mlord:pobox.com>: > o Fix vmalloc() error handling >
This change has a problem. In __vmalloc_area_pages when pmd_alloc fails, the spinlock will not be released. Maybe the following patch is needed? (only compile tested, I don't have SMP)
Michal Schmidt
--- linux-2.4.26-pre2/mm/vmalloc.c Sun Mar 7 20:44:27 2004 +++ linux-2.4.26-pre2.mich/mm/vmalloc.c Sun Mar 7 20:54:02 2004 @@ -183,6 +183,7 @@ static inline int __vmalloc_area_pages ( err: if (address > start) vmfree_area_pages((address - start), address - start); + spin_unlock(&init_mm.page_table_lock); return -ENOMEM; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |