[lkml]   [2004]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] PnP BIOS exception fixes

On Thu, 4 Mar 2004, Brian Gerst wrote:
> This patch fixes two errors in fixup_exception() for PnP BIOS faults:
> - Check for the correct segments used for the BIOS
> - Fix asm constraints so that EIP and ESP are properly reloaded

I'm almost certain that you should NOT use "g" as a constraint, since that
allows the address to be on the stack frame, so when we compile without
frame pointers and the compiler uses a %esp-relative thing for the branch
address, that will totally screw up when we just re-loaded %esp inside the

Can you use "r" instead, and test that it all works for you, and send an
updated patch? Or just explain why I'm wrong.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2009-11-18 23:46    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean