[lkml]   [2004]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Kgdb-bugreport] [PATCH] Kill kgdb_serial
On Thu, Mar 04, 2004 at 10:11:39AM +0530, Amit S. Kale wrote:
> On Wednesday 03 Mar 2004 8:46 pm, Tom Rini wrote:
> > On Wed, Mar 03, 2004 at 11:13:02AM +0530, Amit S. Kale wrote:
> > > kgdb_serial isn't ugly. It's just a function switch, similar to several
> > > of them in the kernel. ppc is ugly, but that's anyway the case because of
> > > so many varieties of ppc. If we are trying to make ppc code clean, it
> > > makes more sense to move this weak function thing into ppc specific files
> > > IMHO.
> >
> > I think you missed the point. The problem isn't with providing weak
> > functions, the problem is trying to set the function pointer. PPC
> > becomes quite clean since the next step is to kill off
> > PPC_SIMPLE_SERIAL and just have kgdb_read/write_debug_char in the
> > relevant serial drivers.
> We can still have one single hardcoded function pointer for ppc and manage
> the rest in ppc specific files.

I think you're still missing the point.

Regardless, the solution to this is what dwmw2 suggested on IRC I
believe, as this should remove all of the #ifdef mess.

Tom Rini
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 14:01    [W:0.073 / U:4.996 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site